Skip to content

Commit b90f484

Browse files
authored
Merge pull request #38 from prysmex/eui-hr
Eui Horizontal Rule
2 parents d83e4a0 + bb4d811 commit b90f484

File tree

9 files changed

+95
-2
lines changed

9 files changed

+95
-2
lines changed
Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
1+
<hr
2+
class={{class-names
3+
componentName="EuiHorizontalRule"
4+
margin=(arg-or-default @margin "l")
5+
size=(arg-or-default @size "full")
6+
}}
7+
/>

addon/helpers/class-names.ts

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,7 @@ interface Options {
2323
grow: number | string;
2424
iconSide: string;
2525
flush: string;
26+
margin: string;
2627
}
2728

2829
/**
@@ -49,7 +50,8 @@ export function classNames(
4950
justifyContent,
5051
columns,
5152
grow,
52-
iconSide
53+
iconSide,
54+
margin
5355
}: Options
5456
): string {
5557
let classes: string[] = [...classNames];
@@ -77,6 +79,7 @@ export function classNames(
7779
classes.push(cssMappings[componentName].properties.grow?.[grow] || '');
7880
classes.push(cssMappings[componentName].properties.iconSide?.[iconSide] || '');
7981
classes.push(cssMappings[componentName].properties.flush?.[flush] || '');
82+
classes.push(cssMappings[componentName].properties.margin?.[margin] || '');
8083
classes = classes.filter(s => isPresent(s));
8184
}
8285

Lines changed: 27 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,27 @@
1+
export const baseClass: string = 'euiHorizontalRule';
2+
3+
export const sizeMapping = {
4+
full: `${baseClass}--full`,
5+
half: `${baseClass}--half`,
6+
quarter: `${baseClass}--quarter`
7+
}
8+
9+
export const marginMapping = {
10+
none: '',
11+
xs: `${baseClass}--marginXSmall`,
12+
s: `${baseClass}--marginSmall`,
13+
m: `${baseClass}--marginMedium`,
14+
l: `${baseClass}--marginLarge`,
15+
xl: `${baseClass}--marginXLarge`,
16+
xxl: `${baseClass}--marginXXLarge`
17+
}
18+
19+
const mapping: ComponentMapping = {
20+
base: baseClass,
21+
properties: {
22+
size: sizeMapping,
23+
margin: marginMapping
24+
}
25+
}
26+
27+
export default mapping;

addon/utils/css-mappings/index.ts

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,7 @@ import EuiBadge from './eui-badge';
2121
import EuiCard from './eui-card';
2222
import EuiButtonEmpty from './eui-button-empty';
2323
import EuiCardSelect from './eui-card-select';
24+
import EuiHorizontalRule from './eui-horizontal-rule';
2425

2526
const mapping: Mapping = {
2627
EuiAccordion,
@@ -44,7 +45,8 @@ const mapping: Mapping = {
4445
EuiBadge,
4546
EuiCard,
4647
EuiButtonEmpty,
47-
EuiCardSelect
48+
EuiCardSelect,
49+
EuiHorizontalRule
4850
}
4951

5052
export default mapping;
Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
export { default } from 'ember-eui/components/eui-horizontal-rule';

tests/dummy/app/controllers/application.js

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -33,6 +33,9 @@ export default class ApplicationController extends Controller {
3333
createItem('Flex', {
3434
href: 'demo.flex'
3535
}),
36+
createItem('Horizontal Rule', {
37+
href: 'demo.horizontal-rule'
38+
}),
3639
createItem('Page', {
3740
href: 'demo.page'
3841
})

tests/dummy/app/router.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -24,5 +24,6 @@ Router.map(function() {
2424
this.route('button');
2525
this.route('health');
2626
this.route('flex');
27+
this.route('horizontal-rule');
2728
})
2829
});
Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
1+
import Route from '@ember/routing/route';
2+
3+
export default class ComponentsHorizontalRule extends Route.extend({
4+
// anything which *must* be merged to prototype here
5+
}) {
6+
// normal class body definition here
7+
}
Lines changed: 42 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,42 @@
1+
<EuiPageHeader>
2+
<EuiPageHeaderSection>
3+
<EuiTitle @size="l">
4+
<h1>
5+
Horizontal Rule
6+
</h1>
7+
</EuiTitle>
8+
</EuiPageHeaderSection>
9+
</EuiPageHeader>
10+
<EuiPageContent>
11+
<EuiPageContentBody>
12+
13+
<EuiTitle @size="l">
14+
Size
15+
</EuiTitle>
16+
<EuiText @size="s"><p>quarter</p></EuiText>
17+
<EuiHorizontalRule @size="quarter" />
18+
<EuiText @size="s"><p>half</p></EuiText>
19+
<EuiHorizontalRule @size="half" />
20+
<EuiText @size="s"><p>full (default)</p></EuiText>
21+
<EuiHorizontalRule @size="full" />
22+
23+
<EuiTitle @size="l">
24+
Margin
25+
</EuiTitle>
26+
<EuiText @size="s"><p>none</p></EuiText>
27+
<EuiHorizontalRule @margin="none" />
28+
<EuiText @size="s"><p>xs</p></EuiText>
29+
<EuiHorizontalRule @margin="xs" />
30+
<EuiText @size="s"><p>s</p></EuiText>
31+
<EuiHorizontalRule @margin="s" />
32+
<EuiText @size="s"><p>m</p></EuiText>
33+
<EuiHorizontalRule @margin="m" />
34+
<EuiText @size="s"><p>l (default)</p></EuiText>
35+
<EuiHorizontalRule @margin="l" />
36+
<EuiText @size="s"><p>xl</p></EuiText>
37+
<EuiHorizontalRule @margin="xl" />
38+
<EuiText @size="s"><p>xxl</p></EuiText>
39+
<EuiHorizontalRule @margin="xxl" />
40+
41+
</EuiPageContentBody>
42+
</EuiPageContent>

0 commit comments

Comments
 (0)