Fix error and warnings for successful Fedora 42 debug build. #14861
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
themanyone
changed the title
themanyone
force-pushed
the
fix_warn_pr
branch
from
2763956 to
896dae4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes one build blocker, and a bunch of fixes for warnings, reducing the size of build logs.
896dae4 (HEAD -> fix_warn_pr, origin/fix_warn_pr, build) WipeTowerIntegration.hpp:48: fix warning about comparing different int types
3d42112 CoolingBuffer.cpp:691: parenthesis suggested
24cbc7f TreeSupport.cpp: shift declared but not used (commented out)
722c4e6 SLAPrint.cpp: using non-reference type to prevent copying
416457c OptionsGroup.cpp:774: fix warning by removing & from string& key
aa36cce GLCanvas3D.cpp: bed_center defined but not used (comment out for now)
879d366 3DBed.cpp: fix warning about comparing different signedness
4b9ba37 TreeModelVolumes.cpp:881: parenthesis suggested
9d1c129 ShortestPath.cpp: fix warning about if guarding
b75e834 MultipleBeds.cpp: fix warning about comparing different signedness
405c325 GCode.cpp: fix warning about comparing different signedness
13ccd95 InterlockingGenerator.cpp: fix warning about comparing different signedness
5cb8f1d ArrangeHelper.cpp: fix warning about comparing different signedness
233fe52 seq_sequential.cpp: missing is indeed 'missing'
The first commit (seq_sequential.cpp: missing is indeed 'missing') blocks debug build.
Ironic when 'missing' goes missing.