Skip to content

Conversation

@n-dony
Copy link

@n-dony n-dony commented Sep 6, 2025

The changes are as follows:

  • stlinit.cpp: Removed fclose(fp) call that was being executed after the fp was already checked to be nullptr.
  • GUI_Factories.cpp: Corrected the conditional check for the menu pointer.

Compilation warnings :

  • /var/tmp/portage/media-gfx/prusaslicer-9999/work/prusaslicer-9999/bundled_deps/admesh/admesh/stlinit.cpp:112:23: warning: argument 1 null where non-null expected [-Wnonnull]
  • /usr/lib/gcc/x86_64-pc-linux-gnu/14/include/g++-v14/bits/char_traits.h:391:32: warning: argument 1 null where non-null expected [-Wnonnull]
  • /var/tmp/portage/media-gfx/prusaslicer-9999/work/prusaslicer-9999/src/slic3r/GUI/GUI_Factories.cpp:1419:27: warning: ‘this’ pointer is null [-Wnonnull]
  • /var/tmp/portage/media-gfx/prusaslicer-9999/work/prusaslicer-9999/src/slic3r/GUI/GUI_Factories.cpp:1424:25: warning: ‘this’ pointer is null [-Wnonnull]
  • /var/tmp/portage/media-gfx/prusaslicer-9999/work/prusaslicer-9999/src/slic3r/GUI/GUI_Factories.cpp:1425:25: warning: ‘this’ pointer is null [-Wnonnull]
  • /var/tmp/portage/media-gfx/prusaslicer-9999/work/prusaslicer-9999/src/slic3r/GUI/GUI_Factories.cpp:1426:25: warning: ‘this’ pointer is null [-Wnonnull]
  • /var/tmp/portage/media-gfx/prusaslicer-9999/work/prusaslicer-9999/src/slic3r/GUI/GUI_Factories.cpp:1430:27: warning: ‘this’ pointer is null [-Wnonnull]
  • /usr/include/wx-3.2/wx/menu.h:156:22: warning: ‘this’ pointer is null [-Wnonnull]

Nico added 2 commits September 6, 2025 20:07
…that it may exhibit random runtime failures.

 * /var/tmp/portage/media-gfx/prusaslicer-9999/work/prusaslicer-9999/src/slic3r/GUI/GUI_Factories.cpp:1419:27: warning: ‘this’ pointer is null [-Wnonnull]
 * /var/tmp/portage/media-gfx/prusaslicer-9999/work/prusaslicer-9999/src/slic3r/GUI/GUI_Factories.cpp:1424:25: warning: ‘this’ pointer is null [-Wnonnull]
 * /var/tmp/portage/media-gfx/prusaslicer-9999/work/prusaslicer-9999/src/slic3r/GUI/GUI_Factories.cpp:1425:25: warning: ‘this’ pointer is null [-Wnonnull]
 * /var/tmp/portage/media-gfx/prusaslicer-9999/work/prusaslicer-9999/src/slic3r/GUI/GUI_Factories.cpp:1426:25: warning: ‘this’ pointer is null [-Wnonnull]
 * /var/tmp/portage/media-gfx/prusaslicer-9999/work/prusaslicer-9999/src/slic3r/GUI/GUI_Factories.cpp:1430:27: warning: ‘this’ pointer is null [-Wnonnull]
 * /usr/include/wx-3.2/wx/menu.h:156:22: warning: ‘this’ pointer is null [-Wnonnull]
…at it may exhibit random runtime failures.

 * /var/tmp/portage/media-gfx/prusaslicer-9999/work/prusaslicer-9999/bundled_deps/admesh/admesh/stlinit.cpp:112:23: warning: argument 1 null where non-null expected [-Wnonnull]
@n-dony n-dony changed the title Fix null pointer warnings and potential runtime errors Fix null pointer warnings Sep 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant