feat(teams): add new checks `teams_security_reporting_enabled` and `defender_chat_report_policy_configured` #7614

andoniaf · 2025-04-25T11:30:38Z

Context

Without proper security reporting enabled, users cannot effectively report suspicious or malicious messages, potentially allowing security threats to go unnoticed.

Description

This checks ensure:

Users are allowed to report security concerns in Teams settings.
Report Submission Policy is properly configured in Defender settings.

Checklist

Are there new checks included in this PR? Yes / No
- If so, do we need to update permissions for the provider? Please review this carefully.
Review if the code is being covered by tests.
Review if code is being documented following this specification https://github.com/google/styleguide/blob/gh-pages/pyguide.md#38-comments-and-docstrings
Review if backport is needed.
Review if is needed to change the Readme.md
Ensure new entries are added to CHANGELOG.md, if applicable.

API

Verify if API specs need to be regenerated.
Check if version updates are required (e.g., specs, Poetry, etc.).
Ensure new entries are added to CHANGELOG.md, if applicable.

License

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

…nt-give-or-request-control

…quest-control' into PRWLR-5811-ensure-external-meeting-chat-is-off

…WLR-5812-ensure-meeting-recording-is-off-by-default

MrCloudSec

@andoniaf, please solve the conflicts in this one.

…y-concerns-in-teams

codecov · 2025-04-29T08:05:36Z

Codecov Report

Attention: Patch coverage is 82.27848% with 14 lines in your changes missing coverage. Please review.

Project coverage is 79.42%. Comparing base (7eec60f) to head (d097fd3).
Report is 3 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #7614      +/-   ##
==========================================
+ Coverage   79.24%   79.42%   +0.18%     
==========================================
  Files         153      156       +3     
  Lines        7062     7188     +126     
==========================================
+ Hits         5596     5709     +113     
- Misses       1466     1479      +13

Flag	Coverage Δ
prowler	`79.42% <82.27%> (+0.18%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
prowler	`79.42% <82.27%> (+0.18%)`	⬆️
api	`∅ <ø> (∅)`

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

…y-concerns-in-teams

...ers/m365/services/teams/teams_security_reporting_enabled/teams_security_reporting_enabled.py

…y-concerns-in-teams

...s/defender/defender_report_policy_configured/defender_report_policy_configured.metadata.json

HugoPBrito

Please, take a look and let me know what you think!

...es/defender/defender_chat_report_policy_configured/defender_chat_report_policy_configured.py

...ers/m365/services/teams/teams_security_reporting_enabled/teams_security_reporting_enabled.py

prowler/providers/m365/services/teams/teams_service.py

Co-authored-by: Hugo Pereira Brito <101209179+HugoPBrito@users.noreply.github.com>

HugoPBrito

Perfect, thanks!

Already solved. Unblock merge.

…efender_chat_report_policy_configured` (#7614) Co-authored-by: Sergio Garcia <hello@mistercloudsec.com> Co-authored-by: Hugo Pereira Brito <101209179+HugoPBrito@users.noreply.github.com>

andoniaf and others added 14 commits April 24, 2025 16:05

feat(teams): add new check

ed1f828

fix(teams): add missing field

e5e49da

feat(teams): add new check teams_meeting_external_chat_disabled

d0d5f11

feat(teams): add new check teams_meeting_recording_disabled

9b54683

Merge branch 'master' into PRWLR-5810-ensure-external-participants-ca…

7e9ebff

…nt-give-or-request-control

chore: update changelog and add missing init

f6cf35a

Merge branch 'PRWLR-5810-ensure-external-participants-cant-give-or-re…

bb07d97

…quest-control' into PRWLR-5811-ensure-external-meeting-chat-is-off

chore: update changelog and add missing init

1e5cb47

Merge branch 'PRWLR-5811-ensure-external-meeting-chat-is-off' into PR…

0a769aa

…WLR-5812-ensure-meeting-recording-is-off-by-default

chore: update changelog and add missing init

3f65963

feat(teams): add new check teams_meeting_presenters_restricted

7e25414

chore: update changelog

636d50b

feat(defender): add report submission policy

2ba2360

feat(teams): add new check teams_security_reporting_enabled

cdf5f8c

andoniaf requested review from a team as code owners April 25, 2025 11:30

chore: update changelog

5593a57

Base automatically changed from PRWLR-5809-ensure-only-organizers-and-co-organizers-can-present to master April 25, 2025 18:34

MrCloudSec previously requested changes Apr 25, 2025

View reviewed changes

andoniaf added 2 commits April 29, 2025 09:49

Merge branch 'master' into PRWLR-5813-ensure-users-can-report-securit…

0e1c90f

…y-concerns-in-teams

fix(defender): update report submission test case

c6b2f9c

andoniaf added 2 commits April 29, 2025 10:20

fix: add missing json_parse

051bb4f

Merge branch 'master' into PRWLR-5813-ensure-users-can-report-securit…

99e6408

…y-concerns-in-teams

MrCloudSec self-requested a review May 5, 2025 13:58

MrCloudSec reviewed May 5, 2025

View reviewed changes

...ers/m365/services/teams/teams_security_reporting_enabled/teams_security_reporting_enabled.py Show resolved Hide resolved

andoniaf added 4 commits May 5, 2025 17:43

Merge branch 'master' into PRWLR-5813-ensure-users-can-report-securit…

67dc22f

…y-concerns-in-teams

feat(m365): separate Defender settings checks in a new check

df5c02c

chore: update changelog

ee7834f

fix: update check metadata

18bc49f

andoniaf changed the title ~~feat(teams): add new check teams_security_reporting_enabled~~ feat(teams): add new checks teams_security_reporting_enabled and defender_report_policy_configured May 5, 2025

andoniaf requested review from MrCloudSec and HugoPBrito May 5, 2025 16:24

MrCloudSec reviewed May 5, 2025

View reviewed changes

...s/defender/defender_report_policy_configured/defender_report_policy_configured.metadata.json Outdated Show resolved Hide resolved

fix: clarify checks objective

ae68e56

HugoPBrito changed the title ~~feat(teams): add new checks teams_security_reporting_enabled and defender_report_policy_configured~~ feat(teams): add new checks teams_security_reporting_enabled and defender_chat_report_policy_configured May 6, 2025

HugoPBrito requested changes May 6, 2025

View reviewed changes

chore: apply suggestions from code review

d097fd3

Co-authored-by: Hugo Pereira Brito <101209179+HugoPBrito@users.noreply.github.com>

HugoPBrito self-requested a review May 6, 2025 09:22

HugoPBrito approved these changes May 6, 2025

View reviewed changes

andoniaf merged commit e5ca51d into master May 6, 2025
12 checks passed

andoniaf deleted the PRWLR-5813-ensure-users-can-report-security-concerns-in-teams branch May 6, 2025 09:30

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat(teams): add new checks `teams_security_reporting_enabled` and `defender_chat_report_policy_configured` #7614

feat(teams): add new checks `teams_security_reporting_enabled` and `defender_chat_report_policy_configured` #7614

Uh oh!

andoniaf commented Apr 25, 2025 •

edited

Loading

Uh oh!

MrCloudSec left a comment

Uh oh!

codecov bot commented Apr 29, 2025 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

HugoPBrito left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

HugoPBrito left a comment

Uh oh!

Uh oh!

Uh oh!

feat(teams): add new checks teams_security_reporting_enabled and defender_chat_report_policy_configured #7614

feat(teams): add new checks teams_security_reporting_enabled and defender_chat_report_policy_configured #7614

Uh oh!

Conversation

andoniaf commented Apr 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Context

Description

Checklist

API

License

Uh oh!

MrCloudSec left a comment

Choose a reason for hiding this comment

Uh oh!

codecov bot commented Apr 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Uh oh!

HugoPBrito left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

HugoPBrito left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

feat(teams): add new checks `teams_security_reporting_enabled` and `defender_chat_report_policy_configured` #7614

feat(teams): add new checks `teams_security_reporting_enabled` and `defender_chat_report_policy_configured` #7614

andoniaf commented Apr 25, 2025 •

edited

Loading

codecov bot commented Apr 29, 2025 •

edited

Loading