Skip to content

feat(sharepoint): add new check related with OneDrive Sync #7589

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

pedrooot
Copy link
Member

Description

This PR adds the check sharepoint_onedrive_sync_restricted_unmanaged_devices.
This check verifies that the OneDrive sync is restricted for unmanaged devices checking that there are allowed domains UIDs under this configuration. Ensuring this setting is configured will prevent users from using the OneDrive for Business Sync client on devices that are not joined to the domains that were defined.

Checklist

API

  • Verify if API specs need to be regenerated.
  • Check if version updates are required (e.g., specs, Poetry, etc.).
  • Ensure new entries are added to CHANGELOG.md, if applicable.

License

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@pedrooot pedrooot requested review from a team as code owners April 23, 2025 10:09
@pedrooot pedrooot changed the title feat(sharepoint): add new check feat(sharepoint): add new check related with OneDrive Sync Apr 23, 2025
Copy link

codecov bot commented Apr 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.66%. Comparing base (5a0fb13) to head (e518d0b).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7589      +/-   ##
==========================================
+ Coverage   75.47%   78.66%   +3.18%     
==========================================
  Files          69      145      +76     
  Lines        4437     6755    +2318     
==========================================
+ Hits         3349     5314    +1965     
- Misses       1088     1441     +353     
Flag Coverage Δ
prowler 78.66% <100.00%> (+3.18%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
prowler 78.66% <100.00%> (+3.18%) ⬆️
api ∅ <ø> (∅)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@andoniaf andoniaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌

@andoniaf andoniaf merged commit 82eecec into master Apr 30, 2025
12 checks passed
@andoniaf andoniaf deleted the PRWLR-5795-ensure-one-drive-sync-is-restricted-for-unmanaged-devices branch April 30, 2025 09:43
jfagoagas pushed a commit that referenced this pull request May 8, 2025
Co-authored-by: Andoni A. <14891798+andoniaf@users.noreply.github.com>
andoniaf added a commit that referenced this pull request May 9, 2025
Co-authored-by: Andoni A. <14891798+andoniaf@users.noreply.github.com>
andoniaf added a commit that referenced this pull request May 9, 2025
Co-authored-by: Andoni A. <14891798+andoniaf@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants