-
Notifications
You must be signed in to change notification settings - Fork 1.7k
feat(sharepoint): add new check related with OneDrive Sync #7589
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
andoniaf
merged 4 commits into
master
from
PRWLR-5795-ensure-one-drive-sync-is-restricted-for-unmanaged-devices
Apr 30, 2025
Merged
feat(sharepoint): add new check related with OneDrive Sync #7589
andoniaf
merged 4 commits into
master
from
PRWLR-5795-ensure-one-drive-sync-is-restricted-for-unmanaged-devices
Apr 30, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #7589 +/- ##
==========================================
+ Coverage 75.47% 78.66% +3.18%
==========================================
Files 69 145 +76
Lines 4437 6755 +2318
==========================================
+ Hits 3349 5314 +1965
- Misses 1088 1441 +353
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
andoniaf
reviewed
Apr 30, 2025
...ricted_unmanaged_devices/sharepoint_onedrive_sync_restricted_unmanaged_devices.metadata.json
Outdated
Show resolved
Hide resolved
…cted-for-unmanaged-devices
andoniaf
approved these changes
Apr 30, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🙌
jfagoagas
pushed a commit
that referenced
this pull request
May 8, 2025
Co-authored-by: Andoni A. <14891798+andoniaf@users.noreply.github.com>
andoniaf
added a commit
that referenced
this pull request
May 9, 2025
Co-authored-by: Andoni A. <14891798+andoniaf@users.noreply.github.com>
andoniaf
added a commit
that referenced
this pull request
May 9, 2025
Co-authored-by: Andoni A. <14891798+andoniaf@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the check
sharepoint_onedrive_sync_restricted_unmanaged_devices
.This check verifies that the OneDrive sync is restricted for unmanaged devices checking that there are allowed domains
UIDs
under this configuration. Ensuring this setting is configured will prevent users from using the OneDrive for Business Sync client on devices that are not joined to the domains that were defined.Checklist
API
License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.