-
Notifications
You must be signed in to change notification settings - Fork 1.7k
feat(aws): add Resource Control Policies (RCP) support #7415
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
…hecks - Added RESOURCE_CONTROL_POLICY to the list of available organization policy types - Added initial check to verify if RCPs are enabled and attached - Added check for S3 security enforcement via RCPs - Added NIST-aligned checks for encryption, IAM controls, logging/monitoring, and network security
- Created docs/requirements.txt with required MkDocs dependencies - Updated .readthedocs.yaml to use pip for dependency installation - This should fix the ReadTheDocs build failure
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @ethanolivertroy , thanks for re-creating the PR! I have made a first revision, could you please add testing to the new checks? You can see how to do them in our Developer Guide.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This check has a false positive if you only have the RCPFullAWSAccess.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #7415 +/- ##
==========================================
- Coverage 92.28% 88.60% -3.68%
==========================================
Files 81 1228 +1147
Lines 7333 35900 +28567
==========================================
+ Hits 6767 31809 +25042
- Misses 566 4091 +3525
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this check is redundant since having RCPs enabled does not mean that the organization is protected. For example, when you enabled RCPs, you have by default an allow all policy that does not enforce anything.
@MrCloudSec going to look these over and address this weekend. TY! |
Context
AWS recently introduced Resource Control Policies (RCPs) as a new type of policy in AWS Organizations. Unlike Service Control Policies (SCPs) which act at the account level, RCPs provide more granular control at the resource level, allowing organizations to implement
stronger security controls across their AWS environment.
This change adds support for detecting and validating effective use of RCPs in AWS Organizations, with a focus on security controls aligned with NIST standards.
Description
This PR adds support for AWS Resource Control Policies with six new checks:
The implementation includes:
Checklist
API
License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.