-
Notifications
You must be signed in to change notification settings - Fork 1.7k
feat(ui): Add notification system for rss feeds #7397
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
feat(ui): Add notification system for rss feeds #7397
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left some comments, @sumit-tft. Please take a look when you have a moment. Thank you
ui/actions/feeds/feeds.tsx
Outdated
import Parser from "rss-parser"; | ||
|
||
// TODO: Need to use the actual feed url | ||
const RSS_FEED_URL = "https://prowler.com/blog/rss"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @sumit-tft , can we add this URL in our .env file please? thank you
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated
variant="outline" | ||
className={cn("relative", "rounded-full", "bg-transparent", "p-2")} | ||
> | ||
<Icon size={18} /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @sumit-tft , can we make sure the size matches the rest of the items?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
# Conflicts: # ui/components/icons/Icons.tsx
Hey @sumit-tft, I was reviewing the functionality of the RSS feed and I noticed the following:
|
Hello, Thank you for reviewing this PR, I discussed with Pablo and made the changes
|
Context
This PR introduces a notification system to the Prowler UI
It adds a bell icon in the top-right corner, fetching alerts from an external RSS feed.
A red dot appears on the bell when new notifications arrive.
Description
feeds-server.tsx
(Server Component) for initial data fetch.feeds-client.tsx
(Client Component) to handle UI updates.feeds.ts
(Action) to fetch the feedscloud.prowler.com
).ui
ordashboard
directory.rss-parser
library to parse rss feedsSteps
feature/add-notification-system
branch.rss-parser
installedhttp://localhost:3000
in your browserNote: To use it in development mode please ensure that
NEXT_PUBLIC_IS_CLOUD_ENV
should be set as true