Skip to content
This repository was archived by the owner on Jan 2, 2024. It is now read-only.

Commit de41407

Browse files
committed
Moved user ID logic
1 parent 711222c commit de41407

File tree

3 files changed

+16
-8
lines changed

3 files changed

+16
-8
lines changed

src/Analytics/BroadcastEvent.php

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,6 @@
22

33
namespace ProtoneMedia\AnalyticsEventTracking\Analytics;
44

5-
use ProtoneMedia\AnalyticsEventTracking\ShouldBroadcastToAnalytics;
65
use TheIconic\Tracking\GoogleAnalytics\Analytics;
76

87
class BroadcastEvent implements EventBroadcaster
@@ -29,7 +28,7 @@ public function withAnalytics(callable $callback): self
2928
* on the events if it exists and then sends the event
3029
* to Google Analytics.
3130
*/
32-
public function handle(ShouldBroadcastToAnalytics $event): void
31+
public function handle($event): void
3332
{
3433
$eventAction = method_exists($event, 'broadcastAnalyticsActionAs')
3534
? $event->broadcastAnalyticsActionAs($this->analytics)

src/Listeners/DispatchAnalyticsJob.php

Lines changed: 15 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@
33
namespace ProtoneMedia\AnalyticsEventTracking\Listeners;
44

55
use Illuminate\Queue\InteractsWithQueue;
6+
use Illuminate\Support\Facades\Auth;
67
use ProtoneMedia\AnalyticsEventTracking\Http\ClientIdRepostory;
78
use ProtoneMedia\AnalyticsEventTracking\Jobs\SendEventToAnalytics;
89

@@ -22,12 +23,25 @@ public function __construct(ClientIdRepostory $clientIdRepository)
2223
*/
2324
public function handle($event): void
2425
{
25-
$job = new SendEventToAnalytics($event, $this->clientIdRepository->get());
26+
$job = new SendEventToAnalytics($event, $this->clientIdRepository->get(), $this->userId());
2627

2728
if ($queueName = config('analytics-event-tracking.queue_name')) {
2829
$job->onQueue($queueName);
2930
}
3031

3132
dispatch($job);
3233
}
34+
35+
private function userId(): ?string
36+
{
37+
if (!config('analytics-event-tracking.send_user_id')) {
38+
return null;
39+
}
40+
41+
if (!Auth::check()) {
42+
return null;
43+
}
44+
45+
return Auth::id();
46+
}
3347
}

src/ServiceProvider.php

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,6 @@
22

33
namespace ProtoneMedia\AnalyticsEventTracking;
44

5-
use Illuminate\Support\Facades\Auth;
65
use Illuminate\Support\Facades\Blade;
76
use Illuminate\Support\Facades\Event;
87
use Illuminate\Support\Facades\Route;
@@ -82,10 +81,6 @@ private function registerAnalytics()
8281
config('analytics-event-tracking.tracking_id')
8382
);
8483

85-
if (config('analytics-event-tracking.send_user_id') && Auth::check()) {
86-
$analytics->setUserId(Auth::id());
87-
}
88-
8984
if (config('analytics-event-tracking.anonymize_ip')) {
9085
$analytics->setAnonymizeIp(1);
9186
}

0 commit comments

Comments
 (0)