Refactor

Author: pascalbaljet

README.md

@@ -43,7 +43,7 @@ GOOGLE_ANALYTICS_TRACKING_ID=UA-01234567-89
 
 This package comes with a `@sendAnalyticsClientId` directive that stores the `Client ID` from the GA front-end to your Laravel backend.
 
-It uses the [Axios HTTP library](https://github.com/axios/axios) the make an asynchronous POST request. Axios was choosen as it is provided by default in Laravel in the `resources/js/bootstrap.js` file.
+It uses the [Axios HTTP library](https://github.com/axios/axios) the make an asynchronous POST request. Axios was choosen because it is provided by default in Laravel in the `resources/js/bootstrap.js` file.
 
 Add the directive somewhere after initializing/configuring GA. The POST request will only be made if the `Client ID` isn't stored yet or when it's refreshed.
 

resources/views/sendCliendId.blade.php

@@ -1,7 +1,7 @@
 ga(function () {
     var clientId = ga.getAll()[0].get('clientId');
 
-    if(clientId != @json(app('analytics-event-tracking-client-id'))) {
+    if(clientId != @json(app('analytics-event-tracking.client-id'))) {
         window.axios.post('/gaid', { id: clientId });
     }
 }

src/ServiceProvider.php

@@ -62,7 +62,7 @@ private function registerClientId()
     {
         $this->app->singleton(ClientIdRepostory::class, ClientIdSession::class);
 
-        $this->app->bind('analytics-event-tracking-client-id', function () {
+        $this->app->bind('analytics-event-tracking.client-id', function () {
             return $this->app->make(ClientIdSession::class)->get();
         });
 

tests/Http/BladeDirectiveTest.php

@@ -15,7 +15,7 @@ public function it_has_a_blade_directive_that_compares_the_current_client_id_to_
         View::addLocation(__DIR__);
 
         $this->assertStringContainsString(
-            app('analytics-event-tracking-client-id'),
+            app('analytics-event-tracking.client-id'),
             view('javascriptView')->render()
         );
     }

tests/Http/ClientIdSessionTest.php

@@ -16,7 +16,7 @@ public function it_stores_the_client_id_by_the_given_key()
 
         $this->assertEquals('1337', session('someKey'));
         $this->assertEquals('1337', $clientIdSession->get());
-        $this->assertEquals('1337', app('analytics-event-tracking-client-id'));
+        $this->assertEquals('1337', app('analytics-event-tracking.client-id'));
     }
 
     /** @test */