Progressbar writer #227
Open
Progressbar writer #227
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use the writer from the logger to write the progressbar output to. The logger is available in every function that uses a progressbar but it is often un(der)used. As the default output writer for loggers is os.Stderr as which is the default for the progressbar as well, this won't change anything for default logger users, but it enables users of the library to redirect the progressbar output.
bdon
reviewed
Apr 15, 2025
| if len(description) > 0 { | ||
| desc = description[0] | ||
| } | ||
| return progressbar.NewOptions64( |
There was a problem hiding this comment.
Is there any way to minimize the amount of configuration here, sticking to the defaults like before?
There was a problem hiding this comment.
The progressbar interface isn't that flexible.
|
Thanks, agreed this would be useful and has a lot of overlap with #117 so maybe we should move to |
|
Is there a requirement to move to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the writer from the logger to write the progressbar output to. The logger is available in every function that uses a progressbar but it is often un(der)used. As the default output writer for loggers is
os.Stderras which is the default for the progressbar as well, this won't change anything for default logger users, but it enables users of the library to redirect the progressbar output.