add contribution guide #7
Conversation
|
|
||
| * Do not make a derivative work or "clone" of a proprietary map like Google, Apple Maps, Mapbox, or Esri. | ||
|
|
||
| 3. The Flavor must be visually distinct from an existing Flavor. |
There was a problem hiding this comment.
The other points are all clear and object, but this one here is very subjective and might lead to many discussions.
My opinion is that we can just drop it. It does not hurt if we have 20 dark and 20 bright styles. It is actually good if users can choose for a variety of styles and pick the one they like the most for their use-case...
There was a problem hiding this comment.
Good point, I can drop this one. My only objection is that if the Flavor API changes, having 20 dark and 20 bright styles means a maintainer needs to manually migrate those, if we guarantee that all Flavors in the repo are compatible with the current major version
There was a problem hiding this comment.
That's true as well...
Up to you. This looks good to me otherwise.
There was a problem hiding this comment.
I clarified this with an example of how to override a few values using the maplibre spread operator, instead of making a whole new Flavor.
No description provided.