fix(php): Fix double to bool casting (use Z_DVAL_P: -0.0 -> false) #24072
+42
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
honglooker
reviewed
Oct 20, 2025
We were reading floats like integers when converting to bool, which made -0.0 incorrectly evaluate to true. Using the proper float accessor fixes this and matches PHP: 0.0 and -0.0 are false; any non-zero float is true.
TomA-R
force-pushed
the
php-double-bool-cast
branch
from
78d7f92 to
7e99380
Compare
TomA-R
commented
Oct 21, 2025
| public function testBoolFromDoubleArrayConstructor() | ||
| { | ||
| $m = new TestMessage(['optional_bool' => -0.0]); | ||
| $this->assertFalse($m->getOptionalBool()); |
There was a problem hiding this comment.
This fails on main and passes on this branch (effectively proving the effectiveness of the fix). Same goes for line 533
github-actions
bot
added
untriaged
honglooker
added
🅰️ safe for tests
github-actions
bot
removed
the
🅰️ safe for tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the
IS_DOUBLEbranch to useZ_DVAL_P(from)instead ofZ_LVAL_P(from). The old code was reading from the integer slot, which isn’t defined for doubles and could return garbage.The new logic follows PHP's own casting rules: 0.0 and -0.0 are
false, everything else (1.5, INF, -INF, NAN) istrue.Added a PHPT test that fails with the old code but passes with this change.
No API changes, just correctness and consistency with PHP itself.