Change BoundedByteString to not subclass LiteralByteString and make LiteralByteString final. #24060
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=80&v=4){kind=small}
copybara-service
bot
force-pushed
the
test_820273934
branch
2 times, most recently
from
6a9215c to
440822d
Compare
…iteralByteString final. The majority of ByteStrings are LiteralByteStrings (and not Bounded ones) in practice since that is what a parse of unknown fields, bytes fields, and string fields with utf-validation-none will construct. This change avoids confusion and keeps the the hottest path as clean and simple as possible. This makes `LiteralByteString.equals(LiteralByteString)` as clean/hot as possible by using Arrays.equals(), and still maintains a hot path for cases where LiteralByteStrings <> BoundedByteStrings are mutually compared. As these types are all implementation details, we can safely reshape the inheritance structure. This diff looks a bit larger than it really is; most of the lines added are simply the fork of the 1-line methods and the diff tool is not smart enough to realize that. PiperOrigin-RevId: 820273934
copybara-service
bot
force-pushed
the
test_820273934
branch
from
440822d to
a8fa082
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change BoundedByteString to not subclass LiteralByteString and make LiteralByteString final.
The majority of ByteStrings are LiteralByteStrings (and not Bounded ones) in practice since that is what a parse of unknown fields, bytes fields, and string fields with utf-validation-none will construct. This change avoids confusion and keeps the the hottest path as clean and simple as possible.
This makes
LiteralByteString.equals(LiteralByteString)as clean/hot as possible by using Arrays.equals(), and still maintains a hot path for cases where LiteralByteStrings <> BoundedByteStrings are mutually compared.As these types are all implementation details, we can safely reshape the inheritance structure.
This diff looks a bit larger than it really is; most of the lines added are simply the fork of the 1-line methods and the diff tool is not smart enough to realize that.