Remove the flag requirement for Bazel+MSVC users. #22632
Merged
+1
−49
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
copybara-service
bot
force-pushed
the
test_783391994
branch
from
030cf41 to
34d2fa5
Compare
As discussed in #20085, we were originally intending to drop support for this combination. With Bazel's recent changes to virtual includes on windows though, we now have ~90 extra characters of runway. This should be more than enough to continue supporting MSVC into the forseeable future. Clang-cl support will be kept in place as an alternative on windows PiperOrigin-RevId: 783798673
copybara-service
bot
force-pushed
the
test_783391994
branch
from
34d2fa5 to
c6ba697
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the flag requirement for Bazel+MSVC users.
As discussed in #20085, we were originally intending to drop support for this combination. With Bazel's recent changes to virtual includes on windows though, we now have ~90 extra characters of runway. This should be more than enough to continue supporting MSVC into the forseeable future. Clang-cl support will be kept in place as an alternative on windows