[protobuf] Use absl endian primitives instead of reimplementing them manually #22588
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
…manually * Specifically, uses: * `absl::endian` * `absl::byteswap` * These were added to Abseil recently, but are included in [Abseil LTS 20250512.1](https://github.com/abseil/abseil-cpp/releases/tag/20250512.1) which was pulled into Protobuf a few weeks ago ([commit](ee68ed1)) * Now unused internal implementation details `BSwap64`, `BSwap32`, and `BSwap16` have been removed * They had a functionally identical implementation to the template function `absl::byteswap` * Also simplified the implementation to make the `ToHost()` and `FromHost()` functions into template functions PiperOrigin-RevId: 733835328
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[protobuf] Use absl endian primitives instead of reimplementing them manually
absl::endianabsl::byteswapBSwap64,BSwap32, andBSwap16have been removedabsl::byteswapToHost()andFromHost()functions into template functions