Skip to content

Conversation

@matthewhorridge
Copy link
Contributor

No description provided.

@matthewhorridge matthewhorridge self-assigned this Nov 6, 2025
Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

public void start(@Nonnull AcceptsOneWidget container, @Nonnull EventBus eventBus) {
editProjectSettings.setEnabled(false);
uploadAndMerge.setEnabled(false);
uploadAndMergeAdditions.setEnabled(false);
uploadSiblingsOrdering.setEnabled(false);

P1 Badge Disable role assignments action before permission check

In start() every menu action is set disabled before invoking the asynchronous capability checks, but the newly added editProjectRoleAssignments action is missing from that list. AbstractUiAction defaults to enabled, so users without EDIT_SHARING_SETTINGS will briefly see and can click the "Role assignments" option before the capability callback runs, letting them navigate to the assignments screen despite lacking permission. Add editProjectRoleAssignments.setEnabled(false); alongside the other initial setEnabled(false) calls so the item stays disabled until the capability check succeeds.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants