Skip to content

Improve display of available ontologies in the ontology selector #1304

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Improve display of available ontologies in the ontology selector #1304

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
107c0b8
Honour language preferences when picking the ontology display name.
gouttegd Sep 5, 2025
4b01013
Sort ontologies by their display name.
gouttegd Sep 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion protege-editor-owl/src/main/java/org/protege/editor/owl/model/OWLWorkspace.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -922,7 +922,12 @@ public void dispose() {

private void rebuildOntologyDropDown() {
try {
TreeSet<OWLOntology> ts = new TreeSet<>(getOWLModelManager().getOWLObjectComparator());
Comparator<OWLOntology> comp = (o1, o2) -> {
String s1 = OWLOntologyCellRenderer.getOntologyLabelText(o1, getOWLModelManager());
String s2 = OWLOntologyCellRenderer.getOntologyLabelText(o2, getOWLModelManager());
return s1.compareTo(s2);
};
TreeSet<OWLOntology> ts = new TreeSet<>(comp);
ts.addAll(getOWLModelManager().getOntologies());
ontologiesList.setModel(new DefaultComboBoxModel<>(ts.toArray(new OWLOntology[ts.size()])));
ontologiesList.setSelectedItem(getOWLModelManager().getActiveOntology());
Expand Down
49 changes: 40 additions & 9 deletions ...-editor-owl/src/main/java/org/protege/editor/owl/ui/renderer/OWLOntologyCellRenderer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
import org.protege.editor.owl.model.OWLModelManager;
import org.semanticweb.owlapi.model.IRI;
import org.semanticweb.owlapi.model.OWLAnnotation;
import org.semanticweb.owlapi.model.OWLLiteral;
import org.semanticweb.owlapi.model.OWLOntology;
import org.semanticweb.owlapi.util.OntologyIRIShortFormProvider;
import org.semanticweb.owlapi.vocab.DublinCoreVocabulary;
Expand All @@ -16,6 +17,8 @@
import javax.swing.JList;

import java.awt.Component;
import java.util.HashMap;
import java.util.Map;
/*
* Copyright (C) 2007, University of Manchester
*
Expand Down Expand Up @@ -89,20 +92,48 @@ private static String formatOntologyLabelText(Optional<IRI> iri, String name) {
}

private static String getOntologyDisplayName(OWLOntology ont) {
String label = null;
String title = null;
Map<String, String> namesByLang = new HashMap<String, String>();
for (OWLAnnotation annot : ont.getAnnotations()) {
if (annot.getValue().isLiteral()) {
IRI property = annot.getProperty().getIRI();
if (property.equals(OWLRDFVocabulary.RDFS_LABEL.getIRI())) {
label = annot.getValue().asLiteral().get().getLiteral();
} else if (property.equals(DublinCoreVocabulary.TITLE.getIRI())) {
title = annot.getValue().asLiteral().get().getLiteral();
} else if (property.equals(DCTERM_TITLE)) {
title = annot.getValue().asLiteral().get().getLiteral();
if (property.equals(OWLRDFVocabulary.RDFS_LABEL.getIRI())
|| property.equals(DublinCoreVocabulary.TITLE.getIRI())
|| property.equals(DCTERM_TITLE)) {
OWLLiteral value = annot.getValue().asLiteral().get();
String lang = value.getLang().toLowerCase();
if (lang == null || lang.isEmpty()) {
namesByLang.put("", value.getLiteral());
} else {
namesByLang.put(lang, value.getLiteral());
int sep = lang.indexOf('-');
if (sep != -1) {
// This is a language dialect (e.g. "en-GB"); we also store it under the
// corresponding language family ("en"), unless we already a title for
// that family.
String langFamily = lang.substring(0, sep);
if (!namesByLang.containsKey(langFamily)) {
namesByLang.put(langFamily, value.getLiteral());
}
}
}
}
}
}
return label != null ? label : title;

String name = null;
for (String langPref : OWLRendererPreferences.getInstance().getAnnotationLangs()) {
name = namesByLang.get(langPref.toLowerCase());
if (name != null) {
return name;
}
}

// No lang match, look for a language-neutral title
name = namesByLang.get("");
if (name == null && !namesByLang.isEmpty()) {
// No lang match and no lang-neutral value, pick whatever we have
name = namesByLang.entrySet().iterator().next().getValue();
}
return name;
}
}