fix(config): also error when env var in config is prefixed or suffixed #1500
+14
−6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes two issues:
snmp_exporter
behaves: if an env var is missing while--config.expand-environment-variables
, it errors while loading the config.I've updated the
README
to reflect that.snmp_exporter
would neither error nor leave the string as-is. Instead,os.Expand
would silently replace the env vars found within the string with""
.I've updated the implementation to also error when the (missing) env var is found within a larger string. A common failure scenario is having a password like
abcd$geh==1
in the config: with--config.expand-environment-variables
, this password would silently be changed toabcd==1
(stripping the env var), so authentication against targets would fail despite having correct auths in the config.Now,
snmp_exporter
errors and complains about the missing variablegeh
.