Skip to content

Add auto-discovery for Directory Services(MicrosoftAD) #757 #1556

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jan 9, 2025
Merged

Add auto-discovery for Directory Services(MicrosoftAD) #757 #1556

merged 4 commits into from
Jan 9, 2025
+103 −0

Conversation

@RuslanMustaev
Copy link
Contributor

@RuslanMustaev RuslanMustaev commented Nov 4, 2024

For the feature request #757

@RuslanMustaev RuslanMustaev force-pushed the feature/auto-discovery-for-directory-services branch 4 times, most recently from bec657b to 4becfcd Compare November 17, 2024 20:37
@RuslanMustaev RuslanMustaev changed the title Add auto-discovery for Directory Services(MicrosoftAD) #757 git logAdd auto-discovery for Directory Services(MicrosoftAD) #757 Nov 17, 2024
@RuslanMustaev RuslanMustaev changed the title git logAdd auto-discovery for Directory Services(MicrosoftAD) #757 Add auto-discovery for Directory Services(MicrosoftAD) #757 Nov 17, 2024
@RuslanMustaev RuslanMustaev force-pushed the feature/auto-discovery-for-directory-services branch from 133d7cd to f835fdd Compare November 17, 2024 22:42
cristiangreco
cristiangreco reviewed Nov 27, 2024
View reviewed changes
Copy link
Contributor

@cristiangreco cristiangreco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Do you mind adding a test like pkg/job/maxdimassociator/associator_api_gateway_test.go?

@RuslanMustaev RuslanMustaev reopened this Nov 27, 2024
@RuslanMustaev
Copy link
Contributor Author

RuslanMustaev commented Nov 27, 2024

Thanks! Do you mind adding a test like pkg/job/maxdimassociator/associator_api_gateway_test.go?

Sure, will take some time.

@RuslanMustaev RuslanMustaev force-pushed the feature/auto-discovery-for-directory-services branch 2 times, most recently from 32599b7 to cc4a7d1 Compare December 3, 2024 02:52
@RuslanMustaev
Add auto-discovery for Directory Services(MicrosoftAD)
d287301 
Signed-off-by: Ruslan Mustaev <ruslan.mustaev@orionhealth.com>
@RuslanMustaev RuslanMustaev force-pushed the feature/auto-discovery-for-directory-services branch from b6dd355 to d287301 Compare December 19, 2024 21:42
cristiangreco
cristiangreco requested changes Jan 9, 2025
View reviewed changes
@cristiangreco
Update pkg/job/maxdimassociator/associator_directoryservice_test.go
41062b2 
Signed-off-by: Cristian Greco <cristian@regolo.cc>
@cristiangreco
Update pkg/job/maxdimassociator/associator_directoryservice_test.go
f3a92ca 
Signed-off-by: Cristian Greco <cristian@regolo.cc>
@cristiangreco cristiangreco merged commit 8262f53 into prometheus-community:master Jan 9, 2025
9 checks passed
@thepalbi thepalbi mentioned this pull request Jan 15, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cristiangreco cristiangreco cristiangreco approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@RuslanMustaev @cristiangreco