-
Notifications
You must be signed in to change notification settings - Fork 160
feat: added devcontainers #10866
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat: added devcontainers #10866
Conversation
- Add VS Code dev container with Java 21 JDK and Gradle support - Include Dockerfile with Debian base to avoid Podman conflicts - Configure non-root nessie user with sudo access - Add port forwarding for Nessie server (19120) - Include comprehensive README with setup instructions This provides a consistent containerized development environment that addresses the platform-specific issues mentioned in CONTRIBUTING.md while enabling safe development without "metal" installation requirements. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
- Add comprehensive dev container documentation as recommended option - Position it prominently before platform-specific manual setup - Highlight benefits: consistent Linux environment, no platform issues - Reference the detailed .devcontainer/README.md for full instructions - Frame manual setup as alternative for those who prefer it This addresses the development environment barriers mentioned in the existing contributing docs by providing a containerized solution. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
2663ec0
to
58a2a64
Compare
The previous commits accidentally removed trailing whitespace from multiple lines. This restores the original formatting to match main while keeping only the new Development Container section addition. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a great addition to Nessie, thank you @norton120!
Checking licensing issues before approving for good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for expanding Nessie development options, @norton120 ! I hope people find it useful :)
Hi @norton120 , Thanks a lot for the effort on this PR! We've noticed that the commits are co-authored by "Claude" ( (From this ASF page about "generative tooling", which contains a pretty good explanation on that topic:) Can you clarify? |
Ah man, this is a whole can of worms. I use Claude Code and Cursor as part of my normal dev workflow, so the distinction between which content was "written by me" vs "written by the tool" is nebulous at best. I believe I had Claude generate the first pass of the markdown, then I made some manual tweaks, then I gave Claude feedback and instructions for another pass, then I made a few finishing touches manually... so who wrote the markdown? If the license is being pedantic about the definition of "generated by a non-human" (not saying it is, I'm saying it is unclear to me), any content where the author leveraged genAI, text autocomplete or even a spell checker is, technically, not copyrightable. I dug around a little on the subject, and the phrase "sufficient human authorship" keeps coming up in reference to copyrightability - but without a practical litmus test of what is "sufficient." It smells like a much bigger question for the ASF to provide real, actionable guidelines for use with the license; and truthfully I wasn't looking to spur a landmark decision over some devenv tweaks. I am happy to gitignore the container files and just use them locally to be safe on the licensing side (in which case this PR will be updated to a |
…we're not double-testing the code), removed some extranious comments
Totally true. The copyright(ability) of AI generated artifacts is totally up in the air.
Yep, there's no "exact measure", it's all subjective, which imposes some risk wrt licensing. We've been discussing this internally. The TL;DR, as you mention, is that it's unclear who the actual author is, because we can only accept contributions from individuals. As much as I would like to, we cannot accept this contribution. If you want, we can leave the PR open, so people can still refer to it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(Adding a "merge blocker" - for future reference)
I want to contribute, but really hate developing on the metal if I can avoid it. This PR creates a devcontainer alternative to the currently described development env in contributing.md