Bump build requirements to Java 21 #735
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Newer Gradle plugins, for example [spotless](https://github.com/projectnessie/cel-java/actions/runs/17985873576/job/51163753246?pr=732#logs), require Java 17 or newer. CI already used Java 17, changed to 21 as the "main" Java matrix job. Also replaced Java 24 w/ Java 25 in the CI matrix. Also updated/fixed README files.
XN137
previously approved these changes
Sep 29, 2025
| * Java 21 or newer, it's a Gradle-wrapper build (it's fast ;) ) | ||
|
|
||
| Runtime requirements: | ||
| * Java 8 or newer |
There was a problem hiding this comment.
just wondering:
if we have a runtime requirement of only java 8, is it intentional that CI only runs tests with 17+ ?
There was a problem hiding this comment.
yea, that's probably fine (was like that forever)
|
Had to revert the Java 24->25 change - the used Gradle version's not ready :( ... and remove Java 17 due to the build requirements |
XN137
approved these changes
Sep 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Newer Gradle plugins, for example spotless, require Java 17 or newer.
CI already used Java 17, changed to 21 as the "main" Java matrix job.
Also updated/fixed README files.