Skip to content

Fix calico/base multi-arch manifest push #637

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 29, 2025

Conversation

hjiawei
Copy link
Collaborator

@hjiawei hjiawei commented Jan 28, 2025

This change moves the slightly different cd-common implementations to each calico-base-cd and calico-go-build-cd target. calico/base multi-arch manifest isn't created properly after the parallel build changes in #636.

Copy link
Collaborator

@rene-dekker rene-dekker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@hjiawei hjiawei merged commit 1dd8953 into projectcalico:master Jan 29, 2025
2 checks passed
@hjiawei hjiawei deleted the fix-multiarch-cd branch January 29, 2025 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants