Trigger calico/go-build auto pin update on successful tag builds #627
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This changeset changes auto `calico/go-build` pin update to trigger only on successful tag builds. SEMAPHORE_WORKFLOW_BRANCH is also set to the master branch by default. Currently, it is always set to SEMAPHORE_GIT_BRANCH which isn't correct for tag builds.
hjiawei
commented
Jan 11, 2025
| @@ -692,7 +692,7 @@ semaphore-run-auto-pin-update-workflow: | |||
| # SEMAPHORE_AUTO_PIN_UPDATE_PROJECT_IDS. | |||
| semaphore-run-auto-pin-update-workflows: | |||
| for ID in $(SEMAPHORE_AUTO_PIN_UPDATE_PROJECT_IDS); do\ | |||
| SEMAPHORE_WORKFLOW_BRANCH=$(SEMAPHORE_GIT_BRANCH) SEMAPHORE_PROJECT_ID=$$ID $(MAKE) semaphore-run-auto-pin-update-workflow; \ | |||
| SEMAPHORE_PROJECT_ID=$$ID $(MAKE) semaphore-run-auto-pin-update-workflow; \ | |||
There was a problem hiding this comment.
For a semaphore tag build, SEMAPHORE_GIT_BRANCH will be something like refs/tags/1.23.4-llvm18.1.8-k8s1.31.4-1. This isn't correct for an auto calico/go-build pin update. This auto update is only planned for the master branch for downstream projects. Once I remove this hard-coded SEMAPHORE_WORKFLOW_BRANCH assignment, it will be master when not defined (defined in line 671).
danudey
approved these changes
Jan 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changeset changes auto
calico/go-buildpin update to trigger only on successful tag builds. SEMAPHORE_WORKFLOW_BRANCH is also set to the master branch by default. Currently, it is always set to SEMAPHORE_GIT_BRANCH which isn't correct for tag builds.Fixes issues seen in this semaphore tag build workflow.