Pin calico/base to release tags #9867
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marvin-tigera
added
release-note-required
hjiawei
commented
Feb 19, 2025
| @@ -204,7 +204,7 @@ endif | |||
| python:3 \ | |||
| bash -c '/usr/local/bin/python release/get-contributors.py >> /code/AUTHORS.md' | |||
|
|
|||
| update-pins: update-go-build-pin | |||
| update-pins: update-go-build-pin update-calico-base-pin | |||
There was a problem hiding this comment.
Normally, we update calico/base together with calico/go-build before each release. This update-pins target will be triggered once we have a new calico/go-build release. Both calico/go-build and calico/base versions will be updated to the latest.
hjiawei
commented
Feb 19, 2025
| @@ -199,7 +199,7 @@ ifeq ($(BUILDARCH),amd64) | |||
| # *-amd64 tagged images for etcd are not available until v3.5.0 | |||
| ETCD_IMAGE = quay.io/coreos/etcd:$(ETCD_VERSION) | |||
| endif | |||
| UBI_IMAGE ?= registry.access.redhat.com/ubi8/ubi-minimal:$(UBI_VERSION) | |||
| UBI_IMAGE ?= registry.access.redhat.com/ubi8/ubi-minimal:latest | |||
There was a problem hiding this comment.
We do microdnf upgrade when building the container image. It essentially moves the tag to latest. We are not really pinning to the UBI_VERSION defined in metadata.mk.
hjiawei
force-pushed
the
pin-calico-base
branch
from
c68ee6c to
546af2a
Compare
marvin-tigera
removed
release-note-required
marvin-tigera
added
release-note-required
hjiawei
added
docs-not-required
coutinhop
approved these changes
Feb 19, 2025
| @echo "latest CALICO_BASE_VER=$(new_ver)" | ||
|
|
||
| bash -c '\ | ||
| if [[ "$(new_ver)" > "$(old_ver)" ]]; then \ |
There was a problem hiding this comment.
today I learned that this "just works" for strings
|
calico/base release tags are pushed in projectcalico/go-build#652. |
hjiawei
force-pushed
the
pin-calico-base
branch
from
546af2a to
71a0087
Compare
This change pins calico/base version to a particular tag instead of `latest`. It resolves issues during a (hash) release when non-amd64 components accidentally pull in amd64 bases.
hjiawei
force-pushed
the
pin-calico-base
branch
from
71a0087 to
b2e64e8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change pins calico/base version to a particular tag instead of
latest. It resolves issues during a (hash) release when non-amd64 components accidentally pull in amd64 bases.Related issues/PRs
Todos
Release Note
Reminder for the reviewer
Make sure that this PR has the correct labels and milestone set.
Every PR needs one
docs-*label.docs-pr-required: This change requires a change to the documentation that has not been completed yet.docs-completed: This change has all necessary documentation completed.docs-not-required: This change has no user-facing impact and requires no docs.Every PR needs one
release-note-*label.release-note-required: This PR has user-facing changes. Most PRs should have this label.release-note-not-required: This PR has no user-facing changes.Other optional labels:
cherry-pick-candidate: This PR should be cherry-picked to an earlier release. For bug fixes only.needs-operator-pr: This PR is related to install and requires a corresponding change to the operator.