Add basic axe core testing for blocks #3570
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taylor-steve
force-pushed
the
3535-headings-axe-tests
branch
2 times, most recently
from
2b05363 to
c00840a
Compare
hackartisan
requested changes
Sep 24, 2025
| end | ||
|
|
||
| it 'is accessible' do | ||
| pending 'accessibility fixes' |
Contributor
There was a problem hiding this comment.
The other pending messages reference an issue, which is really helpful. Could this reference an issue also or otherwise be more specific?
taylor-steve
force-pushed
the
3535-headings-axe-tests
branch
from
c00840a to
18a72a1
Compare
hackartisan
approved these changes
Sep 24, 2025
Contributor
hackartisan
left a comment
hackartisan
left a comment
There was a problem hiding this comment.
👍🏻 This is a good idea for how to demonstrate the issue and enforce its resolution once that resolution is implemented. Until then, it's possible we're adding several pending tests which may remain so indefinitely (at least 1 doesn't look like it's planned work so will probably remain pending). I'm fine with that, but I'd be happier if at least one other person approves before merge.
taylor-steve
force-pushed
the
3535-headings-axe-tests
branch
from
18a72a1 to
28beb9b
Compare
Contributor
|
Discussion in sprint standup was 👍🏻 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #3535
Adds the
axe-core-rspecgem as a dev dependency. Axe core has good support for heading ordering rules, so this will start to give us some feedback as we make changes.I've included these directly in the block specs, sometimes piggy-backing on an existing test, in an attempt to keep the number of new/mostly duplicated feature tests to a minimum. It looks like Blacklight moved away from the
be_accessiblehelper and is now usingbe_axe_cleandirectly so I've done the same.