Skip to content

Conversation

@chrisrlc
Copy link
Contributor

Description

Addresses #3515

Adds note to Feature pages and About pages instructions re: how to reuse slugs after renaming pages.

Screenshot from updated Feature pages dashboard:
Screenshot 2025-09-22 at 12 33 25 PM

@chrisrlc chrisrlc marked this pull request as ready for review September 22, 2025 16:51
@sarah-cul sarah-cul self-requested a review September 23, 2025 13:37
Copy link
Contributor

@sarah-cul sarah-cul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested the branch and everything looks good

<%= render partial: 'header', locals: {f: f} %>
<h2 class="mt-4"><%= t :'.pages_header' %></h2>
<p class="instructions"><%= t :'.instructions' %></p>
<p class="instructions"><%= t :'.instructions_html' %></p>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will result in nested <p> tags which isn't allowed. Change the surrounding <p> to a <div> would work.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated, thank you for catching.

@chrisrlc chrisrlc force-pushed the 3515-page-rename-instructions branch from 352f70b to 9faee2d Compare September 23, 2025 14:31
@chrisrlc chrisrlc force-pushed the 3515-page-rename-instructions branch from 9faee2d to 9d7bd57 Compare September 24, 2025 14:10
@chrisrlc chrisrlc merged commit dfde4c5 into main Sep 24, 2025
6 checks passed
@chrisrlc chrisrlc deleted the 3515-page-rename-instructions branch September 24, 2025 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants