3529 carousel aria attributes #3560
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sarah-cul
force-pushed
the
3529-carousel-aria-labels
branch
from
2fe039b to
f5685e5
Compare
corylown
requested changes
Sep 23, 2025
Contributor
corylown
left a comment
corylown
left a comment
There was a problem hiding this comment.
This addresses the issue.
I don't love adding even more logic into the template. I think if we were implementing this feature now we'd probably use a component instead. But what you have is not out of line with how things are currently implemented. I am wondering if all of the logic could be handled in the javascript instead where it would at least be in one spot? What do you think?
app/views/spotlight/sir_trevor/blocks/_solr_documents_carousel_block.html.erb
Outdated
Show resolved
Hide resolved
Contributor
Author
|
yes, I can work on that |
sarah-cul
force-pushed
the
3529-carousel-aria-labels
branch
from
338637e to
f58d37a
Compare
…cribed by attributes are added
sarah-cul
force-pushed
the
3529-carousel-aria-labels
branch
from
f58d37a to
0914ab2
Compare
corylown
approved these changes
Sep 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
github issue #3529 Controls on the carousel slides need accessibility improvements.
Carousels that did not chose to use the captions will have aria-labels on the buttons: 'Previous item', 'Next item'
Carousels that are using a primary, or secondary caption, or both will have the aria-label on the buttons, but they will also have aria-describedby values so that visitors using screen readers will know what item to expect
Testing
- a test was added to an existing rspec