Skip to content

Conversation

ppalaga
Copy link
Contributor

@ppalaga ppalaga commented Sep 2, 2025

https://issues.redhat.com/browse/NCL-9255

It would be great to get some initial feedback on this idea.

I am open to discuss how the new behavior could be made configurable.

I am ready to add tests and docs once the idea and its implementation is approved.

Checklist:

  • Have you added a note in the CHANGELOG wiki for your change if user-facing?
  • Have you added unit tests for your change?

@ppalaga
Copy link
Contributor Author

ppalaga commented Sep 11, 2025

f171230:

  • Rebased
  • Added the autogenerated completion changes

Any feedback on this idea would be welcome.

@ppalaga
Copy link
Contributor Author

ppalaga commented Sep 21, 2025

Any feedback @jomrazek or anybody else on this the idea to cache source archives locally?

@jomrazek
Copy link
Collaborator

jomrazek commented Sep 22, 2025

Sounds reasonable, I'm not sure how big the improvement is but if it is noticeable to you then great. Let's restest this and see why PR is failing (that would be main reason nobody looked at it I guess)

@jomrazek
Copy link
Collaborator

retest this please

@ppalaga
Copy link
Contributor Author

ppalaga commented Sep 23, 2025

Thanks @jomrazek, I will look at the test failures.
Do you see any need to make the cache configurable at this early stage? E.g. max total size of files to cache, custom directory, etc.?
I am quite sure I can live without those but I can imagine that unbounded grow could get annoying for power users of bacon.

@jomrazek
Copy link
Collaborator

Sorry I was busy with new release, I think it might be sufficient to make using cache optional and add parameter to pig repo and source generation commands to activate it for users who don't care about potential cache size. I will retest it again to see errors as build is alerady gone from our jenkins. I believe last time it complained about autocompletion script which should not be your fault.

@jomrazek
Copy link
Collaborator

retest this please

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants