Skip to content

Conversation

ppalaga
Copy link
Contributor

@ppalaga ppalaga commented Aug 28, 2025

Checklist:

  • Didn't add a note in the CHANGELOG wiki because the change is not user-facing
  • Haven't added unit tests, because it is a refactoring

@ppalaga
Copy link
Contributor Author

ppalaga commented Aug 28, 2025

The most of the changes were done using the following bash script:

#!/bin/bash

for f in $(grep -rl --include='*.java' 'import lombok.' .); do
  echo $f
  java -jar ~/.m2/repository/org/projectlombok/lombok/1.18.38/lombok-1.18.38.jar delombok -p "$f" \
    | sed -e '/Generated by delombok/d' -e '/lombok.Generated/d' \
    > "$f.new"
  mv "$f.new" "$f"
done

@thescouser89 thescouser89 requested a review from jomrazek August 28, 2025 17:41
@jomrazek
Copy link
Collaborator

Hi, can you provide some examples where lombok makes it hard to understand code from a first glance? I'm not telling I never debugged a code where I forgot some lombok annotation and spent significant time figuring out why it is not working but I would say that's not this case and pros of lombok are bigger, at least for me, than cons. I'm not in favor of this change especially in form of @java.lang.Override @java.lang.SuppressWarnings("all") annotations all over the code. Refactored and with support of other developers, sure lets start the discussion.

@ppalaga
Copy link
Contributor Author

ppalaga commented Sep 1, 2025

Let me reply in https://issues.redhat.com/browse/NCL-9254

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants