fix: version validation scripts for release tagging #1364
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: robert-cronin <robert.owen.cronin@gmail.com>
robert-cronin
requested review from
ashnamehrotra and
sozercan
as code owners
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the version validation logic in the release workflow by extracting it from an inline script into a dedicated, testable bash script with comprehensive test coverage. The changes improve maintainability and add proper handling for SemVer pre-release semantics.
- Extracted version validation logic into a standalone, reusable script (
validate_version.sh) - Added special handling for SemVer pre-release vs. final release edge cases that
sort -Vdoesn't handle correctly - Created comprehensive test suite (
test_validation.sh) with 15 test cases covering various version comparison scenarios
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
.github/workflows/scripts/release/validate_version.sh |
New standalone script implementing version validation logic with SemVer pre-release support |
.github/workflows/scripts/release/test_validation.sh |
New test harness with 15 test cases validating version comparison edge cases |
.github/workflows/release.yml |
Refactored to extract tag variables and invoke the new validation script via environment variables |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1364 +/- ##
=======================================
Coverage 39.31% 39.31%
=======================================
Files 42 42
Lines 5927 5927
=======================================
Hits 2330 2330
Misses 3396 3396
Partials 201 201 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
robert-cronin
merged commit 5d2dcb4
into
project-copacetic:main
154 of 162 checks passed
robert-cronin
added a commit
that referenced
this pull request
Nov 3, 2025
Signed-off-by: robert-cronin <robert.owen.cronin@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds more robust checks and tests for releasing an upgrade
Closes #1363
Tested on my own fork: