fix: Non Zero Exit code for no upgradable packages causes build fail

[amanycodes]

The package manager shell commands now always exit with code 0. A marker file is now created within the build context only if upgradable packages are detected. That is read and if no upgradable packages found the sentinel error propagates to patchSingleArchImage and it catches this error and logs the user that the package is not upgradable (in summary table if multi-arch setting).

Attempt to close #1223

[codecov]

Codecov Report

❌ Patch coverage is 32.98969% with 65 lines in your changes missing coverage. Please review.
✅ Project coverage is 39.31%. Comparing base (4bee93a) to head (4c94764).
⚠️ Report is 3 commits behind head on main.

Files with missing lines	Patch %	Lines
pkg/pkgmgr/dpkg.go	17.85%	22 Missing and 1 partial ⚠️
pkg/patch/multi.go	10.00%	16 Missing and 2 partials ⚠️
pkg/patch/single.go	0.00%	11 Missing and 1 partial ⚠️
pkg/pkgmgr/rpm.go	70.00%	5 Missing and 4 partials ⚠️
pkg/pkgmgr/apk.go	57.14%	2 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1274      +/-   ##
==========================================
- Coverage   39.49%   39.31%   -0.19%     
==========================================
  Files          42       42              
  Lines        5879     5927      +48     
==========================================
+ Hits         2322     2330       +8     
- Misses       3361     3396      +35     
- Partials      196      201       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[amanycodes]

@ashnamehrotra @robert-cronin I think the pipeline looks fine. The sentinel error is being outputted but the build is still failing when no upgradable packages are present, even though now the shell give exit code 0. I'm confused as to whether I'm not catching the sentinel error at the correct point in the control flow? Would love to have some eyes on this, Thanks!

[ashnamehrotra]

@amanycodes can we add a CI test for this?

We still want the error on the copa side which is correct, since we do not want to create a "patched" tag when the image is unchanged. We just want to have the exit code changed to "0" so that when copa is running in a pipeline it wouldnt cause a CI failure. Does that make sense?

[ashnamehrotra]

@amanycodes are you still working on this?

[amanycodes]

Hi @ashnamehrotra , I'm back from midsems, and have started working on it.

[ashnamehrotra]

LGTM after rebase

[sozercan]

@amanycodes looks like there are some test failures, can you ptal?