-
Notifications
You must be signed in to change notification settings - Fork 55
Reduce responder tasks size; fix transport scheduling #333
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
PR #333: Size comparison from d8463db to 255121a Full report (8 builds for dimmable-light, onoff-light, onoff-light-bt, rs-matter-core, speaker)
|
Update:
|
Hmmmm,
Wondering which tool to trust? :) (The other targets show no significant differences.) |
686b291
to
e38bfbf
Compare
Interesting... do you know if |
Like many other cargo plug-ins, In any case, what I just found out (stupid me!) is that:
I need to move off from this one, perhaps by just using the native LLVM tooling. |
Or maybe I just fork |
This PR is fixing the following TBD left unsolved in #332
"
Fix the large "responder" future by splitting it into multiple tasks in an embassy-executor task pool. This should reduce these 20KB down to ~ 10KB on x64 and even less for the other targets
"
Additionally, it fixes a bug in the scheduling of the transport tasks, because
matter.run_transport
needs to be called only once, and if there are multiple transports (as in UDP and BTP in our case) they need to be chained together.