Extend TestDeviceLogic with functionality to toggle the cluster state out of band

[ivmarkov]

We have this piece of code which toggles the on-off cluster state on and off every 5 seconds repeated throughout all examples of rs-matter, rs-matter-stack, rs-matter-embassy and esp-idf-matter.

Therefore, I think it makes sense to move it into the TestOnOffDeviceLogic struct rather than copy-pasting it everywhere.

[gemini-code-assist]

Summary of Changes

Hello @ivmarkov, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refactors the common periodic on-off cluster state toggling logic by moving it from individual example applications into the TestOnOffDeviceLogic handler. This change improves code reusability and maintainability by centralizing the behavior and making it configurable via a new constructor parameter. The update streamlines the example codebases, ensuring that the device's state-toggling behavior is consistently managed.

Highlights

• Centralized On/Off Toggling Logic: The periodic on-off toggling functionality, previously duplicated across multiple example applications, has been moved into the TestOnOffDeviceLogic struct. This centralizes the logic and reduces redundancy.
• Configurable Periodic Toggling: The TestOnOffDeviceLogic::new() constructor now accepts a toggle_periodically: bool parameter, allowing examples to explicitly enable or disable the automatic 5-second on-off state changes.
• New run Method in TestOnOffDeviceLogic: An async fn run method has been added to TestOnOffDeviceLogic to encapsulate the periodic toggling behavior, which is executed only when toggle_periodically is set to true.
• Code Cleanup and Simplification: Several example files have been cleaned up by removing the previously duplicated periodic toggling loops and associated unused imports, leading to more concise and maintainable code.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request effectively refactors the periodic on/off toggling logic from various examples into the TestDeviceLogic struct, which is a great improvement for code reuse and maintainability. The changes are clean and well-executed. I have one minor suggestion to further improve the conciseness of the new logic.

[hicklin]

All good. Just have one question.