Skip to content

Conversation

ivmarkov
Copy link
Contributor

Given that esp-hal RC1 is out, I think there is nothing stopping us from finally upgrading to embassy-time 0.5.

Copy link
Contributor

Summary of Changes

Hello @ivmarkov, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on updating core asynchronous runtime dependencies, specifically embassy-time and embassy-time-queue-utils, to their latest versions. This upgrade is prompted by the release of esp-hal RC1, ensuring the project benefits from the most recent features, bug fixes, and performance improvements offered by these foundational crates for embedded asynchronous programming.

Highlights

  • Dependency Upgrade: The embassy-time crate has been upgraded from version 0.4 to 0.5 across the project's Cargo.toml files.
  • Dependency Upgrade: The embassy-time-queue-utils crate has been upgraded from version 0.1 to 0.3.
  • Dependency Management: The embassy-time-queue-utils dependency was removed from the main [dependencies] section in rs-matter/Cargo.toml and updated within the [dev-dependencies] section, indicating a refinement in its usage scope.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@ivmarkov ivmarkov requested a review from bjoernQ October 13, 2025 19:24
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request upgrades embassy-time to version 0.5 and its related utility embassy-time-queue-utils. The changes are well-contained and also include a beneficial refactoring in rs-matter/Cargo.toml by moving a dependency to dev-dependencies. I have made one suggestion to remove what appears to be an unused dependency from the examples.

@ivmarkov ivmarkov merged commit ac9ed0d into project-chip:main Oct 14, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants