Skip to content

Conversation

ivmarkov
Copy link
Contributor

@ivmarkov ivmarkov commented Oct 13, 2025

A few RustCrypto crates (ccm and elliptic_curve) still depend on and re-export generic-array < 1.0, however the last 0.x generic-array release just got deprecated a couple of hours ago.

Until the above crates migrate to generic-array 1.x I think it is fair to suppress the warnings generated by them, as generic-array 0.14 is actually pub-re-exported from them (i.e. it is part of their API) so we don't have a better move in the meantime.

EDIT 1: Also the same warnings' suppression in openssl.rs which uses the hmac RustCrypto module, which has the same issue.

===

EDIT 2: Also updated crypto-bigint to 0.6 as it was still on 0.5.

Copy link
Contributor

Summary of Changes

Hello @ivmarkov, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses deprecation warnings originating from the generic-array crate (version 0.x) that are surfacing due to its re-export by ccm and elliptic_curve RustCrypto crates. The primary goal is to temporarily suppress these warnings by adding #![allow(deprecated)] attributes to the affected Rust files, providing a stop-gap solution until the upstream crates migrate to generic-array 1.x. Additionally, the crypto-bigint dependency has been updated to its latest minor version.

Highlights

  • Deprecation Warning Suppression: Implemented #![allow(deprecated)] in rustcrypto.rs and sc/crypto/rustcrypto.rs to suppress warnings from generic-array 0.x, which is re-exported by ccm and elliptic_curve crates, until they update to generic-array 1.x.
  • Dependency Update: Updated the crypto-bigint dependency in Cargo.toml from version 0.5 to 0.6.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@ivmarkov
Copy link
Contributor Author

Also updated crypto-bigint to 0.6 as it was still on 0.5.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request suppresses deprecation warnings originating from the generic-array crate by adding #![allow(deprecated)] to rs-matter/src/crypto/rustcrypto.rs and rs-matter/src/sc/crypto/rustcrypto.rs. The comments explaining that this is a temporary workaround are clear and helpful. The PR also updates the crypto-bigint dependency to v0.6, which requires the removal of an unused import. The changes are correct and address the issue effectively. For better clarity, consider updating the pull request description to also mention the crypto-bigint dependency update.

@ivmarkov ivmarkov force-pushed the fix-clippy-warnings branch from 593244c to 5cf76a1 Compare October 13, 2025 17:37
@ivmarkov ivmarkov requested review from bjoernQ and hicklin October 13, 2025 17:55
@ivmarkov ivmarkov merged commit 83eec9e into project-chip:main Oct 13, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants