Explicit path expansion iterator #212
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As much as I love
Iterator
monadic comprehensions (flat_map
and friends), the IM path expansion logic innode.rs
- which was using those - was resulting in huge iterators w.r.t. memory.The rewrite of the path expansion logic in
node.rs
to use an explicitPathExpander
iterator with mutable state saves ~ 5K RAM.While more risky, the mutable logic is covered with unit tests.
Net-net I don't think this change would increase the codebase size, because while
PathExpander
is more verbose - methods fromendpoint.rs
andcluster.rs
got retired, as these are no longer necessary with the explicitPathExpander
.