-
Notifications
You must be signed in to change notification settings - Fork 123
Swatch Storybook #1296
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Swatch Storybook #1296
Conversation
24bee6e to
4190e77
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving, but agree with Craig's minor copy change suggestion. Thanks for helping document the Design System!
3c86901 to
967341c
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #1296 +/- ##
==========================================
- Coverage 95.27% 95.26% -0.01%
==========================================
Files 194 194
Lines 2264 2262 -2
Branches 387 387
==========================================
- Hits 2157 2155 -2
Misses 55 55
Partials 52 52
☔ View full report in Codecov by Sentry. |
|
Ok I've gotten the unit tests buttoned up and made that small copy change. |
96a66ed to
851ce58
Compare
Update packages/core/src/Swatch/Swatch.stories.tsx Co-authored-by: Craig Palermo <3260642+craigpalermo@users.noreply.github.com> Update packages/core/src/Swatch/Swatch.stories.tsx Co-authored-by: Craig Palermo <3260642+craigpalermo@users.noreply.github.com>
851ce58 to
5142c4d
Compare
Updating the storybook for the Swatch component utilizing the updated pcln-docs-utils library for documentation.