Skip to content

Conversation

@akito-nak
Copy link

Updating the storybook for the Swatch component utilizing the updated pcln-docs-utils library for documentation.

@akito-nak akito-nak force-pushed the feat/docs-for-swatch branch 3 times, most recently from 24bee6e to 4190e77 Compare June 7, 2023 21:19
@akito-nak akito-nak marked this pull request as ready for review June 7, 2023 21:20
Copy link
Collaborator

@trenaryja trenaryja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving, but agree with Craig's minor copy change suggestion. Thanks for helping document the Design System!

@akito-nak akito-nak force-pushed the feat/docs-for-swatch branch 7 times, most recently from 3c86901 to 967341c Compare June 8, 2023 22:37
@codecov
Copy link

codecov bot commented Jun 8, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.01 ⚠️

Comparison is base (fe2e094) 95.27% compared to head (5142c4d) 95.26%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1296      +/-   ##
==========================================
- Coverage   95.27%   95.26%   -0.01%     
==========================================
  Files         194      194              
  Lines        2264     2262       -2     
  Branches      387      387              
==========================================
- Hits         2157     2155       -2     
  Misses         55       55              
  Partials       52       52              
Impacted Files Coverage Δ
packages/core/src/Swatch/index.ts 100.00% <ø> (ø)
packages/core/src/Swatch/Swatch.tsx 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@akito-nak
Copy link
Author

Ok I've gotten the unit tests buttoned up and made that small copy change.

@craigpalermo craigpalermo force-pushed the feat/docs-for-swatch branch 6 times, most recently from 96a66ed to 851ce58 Compare July 10, 2023 17:28
Update packages/core/src/Swatch/Swatch.stories.tsx

Co-authored-by: Craig Palermo <3260642+craigpalermo@users.noreply.github.com>

Update packages/core/src/Swatch/Swatch.stories.tsx

Co-authored-by: Craig Palermo <3260642+craigpalermo@users.noreply.github.com>
@craigpalermo craigpalermo force-pushed the feat/docs-for-swatch branch from 851ce58 to 5142c4d Compare July 10, 2023 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants