Skip to content

Use the latest submodule #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Use the latest submodule #2

wants to merge 6 commits into from

Conversation

phreed
Copy link

@phreed phreed commented May 29, 2025

All the changes I made were already in the master branch of https://github.com/fabiangreffrath/crispy-doom .
The following was what was actually needed:

cd src
git fetch
git checkout origin/master
cd ..
git add src
git commit -m "update to latest commit"
pixi run start

@phreed
Copy link
Author

phreed commented May 29, 2025

The crispy-doom-7.0 tag did not have all the needed changes, so I reverted back to the master branch.
The upstream should probably make a new tag (or branch).

@phreed
Copy link
Author

phreed commented May 29, 2025

I do not use submodules myself so I am not sure if this is the proper way to update the submodule src.

I am thinking that the following is a better approach because it is more explicit.

git config -f .gitmodules submodule.src.branch master
git submodule update --remote

Copy link
Collaborator

@ruben-arts ruben-arts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update, it works for me.

Co-authored-by: Ruben Arts <ruben@prefix.dev>
@phreed
Copy link
Author

phreed commented Jun 10, 2025

Can this get promoted?
I would like to delete my PR repository.

@@ -1,3 +1,4 @@
[submodule "src"]
path = src
url = https://github.com/fabiangreffrath/crispy-doom
branch = master

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we maybe point at a specific commit (latest in master is fine) for reproducibility?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree. I would prefer release branches.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants