-
Notifications
You must be signed in to change notification settings - Fork 1
Use the latest submodule #2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
The crispy-doom-7.0 tag did not have all the needed changes, so I reverted back to the |
I do not use submodules myself so I am not sure if this is the proper way to update the submodule I am thinking that the following is a better approach because it is more explicit. git config -f .gitmodules submodule.src.branch master
git submodule update --remote |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the update, it works for me.
Co-authored-by: Ruben Arts <ruben@prefix.dev>
Can this get promoted? |
@@ -1,3 +1,4 @@ | |||
[submodule "src"] | |||
path = src | |||
url = https://github.com/fabiangreffrath/crispy-doom | |||
branch = master |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we maybe point at a specific commit (latest in master
is fine) for reproducibility?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree. I would prefer release branches.
All the changes I made were already in the master branch of https://github.com/fabiangreffrath/crispy-doom .
The following was what was actually needed: