feat(py-pixi): Add option to create ProjectModelV1 from json and dict
#373
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baszalmstra
reviewed
Sep 23, 2025
daenny
force-pushed
the
feat/add-deserialize
branch
2 times, most recently
from
299e27f to
ad8fa7e
Compare
|
You mean like this? |
daenny
changed the title
ProjectModelV1 from jsonProjectModelV1 from json and dict
|
Yeah! |
baszalmstra
approved these changes
Sep 23, 2025
nichmor
approved these changes
Sep 23, 2025
| return instance | ||
|
|
||
| @classmethod | ||
| def from_dict(cls, data: Mapping[str, Any] | dict[str, Any]) -> "ProjectModelV1": |
There was a problem hiding this comment.
I think it should be Dict instead of dict
There was a problem hiding this comment.
yeah I adjusted it for now for consistency.
I think, if as we discussed on discord target minimum python 3.10, then all the typing should go to the builtins:
https://peps.python.org/pep-0585/#id6
The deprecated functionality may eventually be removed from the typing module. Removal will occur no sooner than Python 3.9’s end of life, scheduled for October 2025.
daenny
force-pushed
the
feat/add-deserialize
branch
2 times, most recently
from
ddc1036 to
2e84d89
Compare
daenny
force-pushed
the
feat/add-deserialize
branch
from
2e84d89 to
d1df14f
Compare
|
I see two approvals, so lets merge! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this we can write better tests for the
pixi-buid-rosbackend.