ci: split building, aggregating and uploading in separate jobs #171
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should also make it easier for external repositories to depend on these artifacts
Hofer-Julian
force-pushed
the
ci/split-ci-job
branch
from
02e0c07 to
fe3b82e
Compare
This reverts commit 5dab5fc.
nichmor
reviewed
May 27, 2025
| workflow_dispatch: | ||
|
|
||
|
|
||
| name: "Build and publish backends" | ||
| name: "Conda Packages" |
There was a problem hiding this comment.
maybe we can change the name and use a verb to describe what we are doing in this workflow?
There was a problem hiding this comment.
That's what I do in the job name.
So you see something like: "Conda Packages/Build`
| @@ -8,11 +8,10 @@ on: | |||
| - "pixi-build-rust-v[0-9]+.[0-9]+.[0-9]+" | |||
| # Build all backends on main branch | |||
| branches: [main] | |||
| pull_request: | |||
There was a problem hiding this comment.
we don't want to run it on every pull_request to ensure that is buildable?
There was a problem hiding this comment.
Technically yes.
But it takes really long, since we have no caching and our macOS runners are always starved. Until we fix that, I think we have to stick with main
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should also make it easier for external repositories to depend on these artifacts. I've also simplified the matrix generator and renamed a few things to make them more readable