fix: unset linker for osx-64 and build backends with rattler-build
#163
+144
−109
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Hofer-Julian
commented
May 21, 2025
•
Hofer-Julian
commented
- unset linker on osx-64 because of release builds using rustc 1.86.0 on macOS Ventura (intel) SDK exhibit incorrect behaviour rust-lang/rust#140686
- move to recipes, since we can't unset env vars
- revert changes to activation script, since they didn't make a lot of sense
This reverts commit 60b5d1e.
- unset linker on osx-64 because of rust-lang/rust#140686 - move to recipes, since we can't unset env vars
Hofer-Julian
changed the title
Hofer-Julian
changed the title
rattler-build
|
For some reason this fails locally for me with |
Hofer-Julian
commented
May 21, 2025
Comment on lines
+18
to
+21
| - if: osx and x86_64 | ||
| then: | ||
| # use the default linker for osx-64 as we are hitting a bug with the conda-forge linker | ||
| - unset CARGO_TARGET_X86_64_APPLE_DARWIN_LINKER |
There was a problem hiding this comment.
That's the relevant bit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.