Skip to content

Allow viewing unlisted group pages when in group #12451

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
+3 −2
Open

Allow viewing unlisted group pages when in group #12451

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6418488
Allow viewing unlisted group pages when in group
Hiviexd Oct 7, 2025
f915ad4
Use a group that has a listing in SanityTest group factory
Hiviexd Oct 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion app/Http/Controllers/GroupsController.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,8 @@ class GroupsController extends Controller
public function show($id)
{
$group = app('groups')->byIdOrFail($id);
abort_unless($group->hasListing(), 404);
abort_if($group->identifier === 'default', 404);
priv_check('GroupShow', $group)->ensureCan();

$currentMode = default_mode();
$users = $group->users()
Expand Down
2 changes: 1 addition & 1 deletion tests/Browser/SanityTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -259,7 +259,7 @@ private static function createScaffolding()
]);

// factory for /g/*
self::$scaffolding['group'] = Group::first();
self::$scaffolding['group'] = Group::where('group_type', 1)->first();

// factory for comments
self::$scaffolding['comment'] = Comment::factory()->create([
Expand Down
Loading