Fix unrecoverable error when opening native db #95
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When opening a native database fails (for instance because the open factory is misconfigured and sends an invalid statement as a open pragma), we don't properly report this error to the client.
I would expect it to be reported through the
initialize()
future, but that actually misses the error. Also, the error is always reported as an unhandled exception which can easily crash the app.This fixes these issues by:
SqliteDatabaseImpl.initialized
reportSqliteConnectionImpl.initialized
instead of an always-completed future.SqliteoConnectionImpl
, makeisInitialized
point to_open
. Previously,_open
was unawaited which caused an unhandled exception if an exception was thrown there.ParentPortClient
, don't usesendPortFuture.then()
. Attaching a first listener without an error handler used to also cause unhandled exceptions for reasons I'm not sure I understand. As an alternative we can set theSendPort
field in the only place whereinitCompleter.complete
is called.