Make watch queries easier to cancel #92
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This refactors our
watch
query stream implementation slightly:FIXME
comment inwatch()
, this refactors the stream implementation there to use stream combinators instead ofasync*
. As that comment explains, cancelling the stream might run the query another time which is not typically what users want._throttleStream
implementation, also usingasync*
, had a similar issue where it couldn't be cancelled efficiently when it's in theawait Future.delayed(timeout);
stage. I've rewritten that method with a manual stream subscription to be more explicit about how we deal with downstream listeners pausing / cancelling the stream (personally, I find the exact semantics ofasync*
quite hard to understand).