Fix deadlock on immediate connect call #272
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- powersync_core@1.2.4 - powersync_attachments_helper@0.6.18+6 - powersync_sqlcipher@0.1.5+4 - powersync@1.12.4
rkistner
approved these changes
Apr 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the
connectInternal()method used to establish a connection to the sync service, we awaitinitialize(). That can be a problem whenconnect()is the first call on the database, because writing the schema also acquires the lock used to guardconnectInternal().This fixes the issue by awaiting
initialize()inconnect(), before acquiring the sync connect lock and callinginitialize(). I've also added a test callingconnect()immediately after opening the database to validate this.This is the second time I get to fix this exact regression, yikes 😬 At least in Kotlin we've not seen too many concurrency issues after that though...