Default Param for CrudBatch Complete #47
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR adds a default value for the optional writeCheckpoint parameter in the CrudBatch.complete method.
- Adds a protocol extension to allow calling complete() without explicitly supplying a nil parameter.
- Updates tests to verify that calling complete() succeeds without a writeCheckpoint argument.
- Updates the CHANGELOG to document the change.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| Tests/PowerSyncTests/CrudTests.swift | Adds a test case to ensure complete() can be called without specifying nil. |
| Sources/PowerSync/Protocol/db/CrudBatch.swift | Provides a protocol extension with a default nil parameter for complete(). |
| CHANGELOG.md | Documents the default nil parameter change for complete(). |
simolus3
approved these changes
May 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
The current
CrudBatchprotocol does not provide a default value for thecompletemethod's optionalwriteCheckpointparameter. This PR adds a Protocol extension which provides the default value.