fix: missing data warning only when both data and error are empty

[romansp]

Closes #675.

Ensures that missing data warning is only logged if both this.staged is STAGED_NO_VALUE and this.stagedError is null.

Summary by CodeRabbit

• Bug Fixes
  • Improved warning messages during development to only appear when there is neither staged data nor a staged error, reducing unnecessary warnings for users.

[coderabbitai]

Walkthrough

The conditional logic for logging a development warning in the commit method of several data loader classes was updated. Now, the warning is only triggered if both the staged data is absent and no staged error is present, refining when the warning appears during development.

Changes

Files	Change Summary
src/data-loaders/defineColadaLoader.ts, src/data-loaders/defineLoader.ts	Updated commit method to only warn if both staged data is absent and no staged error is present.
src/data-loaders/defineQueryLoader.ts, src/data-loaders/defineVueFireLoader.ts	Same update: commit method now checks both staged data and staged error before warning in development mode.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Note

⚡️ Unit Test Generation - Beta

CodeRabbit's unit test generation is now available in Beta! Automatically generate comprehensive unit tests for your code changes, ensuring better test coverage and catching edge cases you might miss. Our AI analyzes your code structure and creates tests that follow best practices and your project's testing patterns. Learn more here, or just try it under ✨ Finishing Touches.

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 3882d6a and cac06d8.

📒 Files selected for processing (4)

• src/data-loaders/defineColadaLoader.ts (1 hunks)
• src/data-loaders/defineLoader.ts (1 hunks)
• src/data-loaders/defineQueryLoader.ts (1 hunks)
• src/data-loaders/defineVueFireLoader.ts (1 hunks)

🔇 Additional comments (4)

src/data-loaders/defineColadaLoader.ts (1)

338-338: Logical improvement to warning condition.

The added stagedError === null check prevents false warnings when an error is staged without data, which is a valid state.

src/data-loaders/defineVueFireLoader.ts (1)

162-162: Consistent implementation across loader types.

Same logical improvement as other loaders, ensuring uniform behavior.

src/data-loaders/defineQueryLoader.ts (1)

214-214: Warning condition refined correctly.

Consistent with other loader implementations in preventing false warnings.

src/data-loaders/defineLoader.ts (1)

284-284: Comprehensive fix across all loader types.

Final piece completing the consistent warning condition refinement.

✨ Finishing Touches

• 📝 Generate Docstrings

🧪 Generate unit tests

❌ Error creating Unit Test PR.

• Create PR with unit tests
• Commit unit tests in branch fix/known-errors-no-staged-data-warning
• Post copyable unit tests in a comment

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai generate unit tests to generate unit tests for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Note

Unit test generation is an Early Access feature. Expect some limitations and changes as we gather feedback and continue to improve it.

---

Generating unit tests... This may take up to 20 minutes.