Skip to content

fix(markdown-stream): normalize tag name comparison #2000

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 22, 2025
Merged

Conversation

gadenbuie
Copy link
Collaborator

Follow up to #1996 with a small bugfix

@schloerke
Copy link
Collaborator

lol. the failing is unrelated to this PR.

Plotly seems to have updated 3 hrs ago and broken their types.

@schloerke
Copy link
Collaborator

@karangattu Can you check out the failures above to see if we can fix them? Thank you!

@gadenbuie gadenbuie changed the title fix: normalize tag name comparison fix(markdown-stream): normalize tag name comparison May 15, 2025
@gadenbuie gadenbuie requested a review from cpsievert May 20, 2025 19:04
Copy link
Collaborator

@cpsievert cpsievert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, and sorry for missing this!

@gadenbuie gadenbuie merged commit 2b4d1a0 into main May 22, 2025
54 checks passed
@gadenbuie gadenbuie deleted the fix/chat-scroll branch May 22, 2025 00:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants