Skip to content

fix(Chat): autoresize input height correctly and independent of shiny.js #1997

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 13, 2025

Conversation

cpsievert
Copy link
Collaborator

Follow up to rstudio/shiny#4210 (and consequently #1986) which effectively removed the global listeners to <textarea> input changes, and made them local to the textAreaInput() binding.

This PR gets the autoresize behavior working again, but in a self-contained manner

@cpsievert cpsievert requested review from Copilot and gadenbuie May 12, 2025 23:44
Copilot

This comment was marked as outdated.

Copy link
Collaborator

@gadenbuie gadenbuie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@cpsievert cpsievert merged commit e779c84 into main May 13, 2025
54 checks passed
@cpsievert cpsievert deleted the fix/chat-autoresize-height branch May 13, 2025 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants