-
Notifications
You must be signed in to change notification settings - Fork 100
feat(bookmarking): Add support for ui.Chat bookmarking #1951
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 33 commits
Commits
Show all changes
43 commits
Select commit
Hold shift + click to select a range
c53934d
Commit before pivoting to using new client state class / chatlas
schloerke f15e6d0
Add chatlas as a dev github source
schloerke 2cd9886
First pass at `chat.enable_bookmarking()`
schloerke e8346e7
Init incomplete example apps
schloerke b1875c4
Merge branch 'main' into bookmark-chat
schloerke 60660a6
Require `chatlas>=0.6.0`
schloerke 22fc7bc
Merge branch 'bookmark-chat' of https://github.com/posit-dev/py-shiny…
schloerke 06c8e09
Add `ClientWithState` docs
schloerke fdae6e2
Remove unused new attr
schloerke 57c93ae
Try to only import chatlas directly; Move checks to top; Add raises s…
schloerke 4292d18
Use `on` and `store` for param names
schloerke 0761374
Rename cancel callback methods
schloerke e3f52b0
Remove unnecessary check
schloerke 59fc8bb
Use function to help with consistent behavior for appending init mess…
schloerke 259bd41
Apply suggestions from code review
schloerke 4c6c6b3
Document `on`; Document express version
schloerke d4bcd3e
Enable bookmarking in templates
schloerke 56bd3c2
Fixes
schloerke a7ef7be
Remove unused example app
schloerke 45de2ae
Rename variable
schloerke 7d02692
Apply suggestions from code review
schloerke 593425f
Use `state=` not `value=`
schloerke df344b1
Update template with suggested comment
schloerke f51c0be
Rename parameters back to `bookmark_store` and `bookmark_on`
schloerke 895a640
Link to Bookmark class in docs; Add Returns
schloerke e8a3b12
Update CHANGELOG.md
schloerke 3f6f65f
Tests
schloerke f86abb8
Move most of chatlas logic to `_chat_bookmark.py`
schloerke d319227
Rearrange sections to co-locate UI together and client together
schloerke 63c2dfb
lint
schloerke 97efb12
Use pydantic json objects, not str for serialization
schloerke cfef02b
Update CHANGELOG.md
schloerke 51d1847
Use fake key
schloerke c6f66f0
Use chatlas >= 0.6.1
schloerke a044f39
check if this helps webkit url assertion
karangattu 126b41e
add some timeout for webkit browser tests
karangattu 1bca258
bump it to 8 secs to see if it is a timing issue
karangattu 35dbc75
bump it to 30 secs
karangattu ece58f7
bump timeout to 30 secs :(
karangattu 800d03c
default is 30 seconds, duh
karangattu b80f8b1
explicit 30 sec wait
karangattu 4e17e85
wait up to 30 secs
karangattu 0af0826
add missing import
karangattu File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.